Skip to content

Train loop stops #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2021
Merged

Train loop stops #18

merged 3 commits into from
Jun 4, 2021

Conversation

@msheller
Copy link
Collaborator

@msheller msheller commented Jun 4, 2021

Includes multiple updates/fixes:

FIXES:

  • Train loop now correctly exits when MAX_SIMULATION_TIME is exceeded
  • Simulated time now correctly includes second validation execution for locally updated model

UPDATES:

  • Documentation improvements, particularly in the notebook for the final experiment configuration
  • experiment run function now returns a pandas dataframe with the scoring metrics for each round

msheller added 3 commits June 3, 2021 15:53
@msheller
Train loop stops between rounds once MAX_SIMULATION_TIME has passed. …
d4b9a90 
…Note that the final round's model will not have been scored, which prevents competitors from abusing an extra long final round
@msheller
Training loop breaks, experiment returns metrics in dataframe, improv…
d4c68ad 
…ed documentation in multiple places, validation time for local model now included
@msheller
Removed unnecessary cell
da26b46
sarthakpati
sarthakpati approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati merged commit b4c783b into main Jun 4, 2021
@sarthakpati sarthakpati deleted the train_loop_stops branch June 9, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

@psfoley psfoley Awaiting requested review from psfoley

@alexey-gruzdev alexey-gruzdev Awaiting requested review from alexey-gruzdev

@brandon-edwards brandon-edwards Awaiting requested review from brandon-edwards

@ujjwalbaid0408 ujjwalbaid0408 Awaiting requested review from ujjwalbaid0408

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msheller @sarthakpati