Skip to content

Add type hinting to Atari envs #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

dm-ackerman
Copy link
Contributor

Description

This adds type hinting to the atari envs

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@David-GERARD David-GERARD self-requested a review April 18, 2025 14:41
@David-GERARD David-GERARD self-assigned this Apr 18, 2025
@David-GERARD David-GERARD added the enhancement New feature or request label Apr 18, 2025
@David-GERARD David-GERARD added this to the 1.25.1 milestone Apr 18, 2025
Copy link
Collaborator

@David-GERARD David-GERARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@David-GERARD David-GERARD merged commit 405e71c into Farama-Foundation:master May 15, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants