Remove duplicate code in RLCard environments #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions were identical in all envs. They have been moved to single file and imported into the envs.
These were the same code in multiple files, they are now in a single file and imported as needed.
The base rlcard env already has a step() function. The envs just called that with an added render call. The render call was added to the base step() function.
Almost all of Texas Hold'em and the no limit version are the same. This makes one a subclass of the other to remove duplicate code.
This isn't an enviornment file, it should be ignored when making env docs.
David-GERARD
approved these changes
Apr 14, 2025
David-GERARD
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RLCard envs had duplicate functions - step, get_image, get_font, calculate_height, calculate_width, calculate_offset. These were repeated in most/all files and identical. They are now in a utils file and imported as needed.
Additionally, TexaHold'em and no limit TexasHold'em were nearly identical code. One now is a child class of the other to remove duplicate code.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.