Fix pyright type error to assert that actions can't be an int. #1270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I ran
pre-commit run --all-files
locally, there were two pyright errors, and I think the error is valid - numpy doesn't provide enough type context to tell pyright thattolist()
will not return a scalar if the instance isn't a scalar. Sincenp.flatnonzero
never returns a scalar, asserting that the return value oftolist()
is never an int seems reasonable to fix pyright error.Fixes #1269 .
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.