Fix rgba value in oven_asset.xml to be in [0,1]
#262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mujoco xml docs state that "All [rgba] components should be in the range [0 1]." https://mujoco.readthedocs.io/en/stable/XMLreference.html#asset-material MuJoCo's parser clearly let's this through. But it seems that mine is a little more strict. I checked with the original author @abhishekunique, and he confirmed that it's just a bug (from his original work), and that it should be fixed.
This was referenced Jan 13, 2025
Kallinteris-Andreas
changed the title
oven_asset.xml to be in [0,1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mujoco xml docs state that "All [rgba] components should be in the range [0 1]."
https://mujoco.readthedocs.io/en/stable/XMLreference.html#asset-material
MuJoCo's parser clearly let's this through. But it seems that mine is a little more strict.
I checked with the original author @abhishekunique, and he confirmed that it's just a bug (from his original work), and that it should be fixed.
Related to RobotLocomotion/drake#22445.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)