Skip to content

Fix list index error when goal_cell and reset_cell are passed as options in PointMaze env #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

gauthamvasan
Copy link
Contributor

@gauthamvasan gauthamvasan commented Aug 2, 2023

Description

This PR fixes an assertion error that arises when a specific goal_cell or reset_cell are passed as options in the point_maze env.

Fixes #163

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2023-08-01 at 9 05 11 PM

Checklist:

  • I have run the pre-commit checks with
    pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rodrigodelazcano
Copy link
Member

Thanks a lot @gauthamvasan . Would it be possible to also add a couple of tests for reset_cell and goal_cell? You can add them in the following test files: https://github.com/Farama-Foundation/Gymnasium-Robotics/tree/main/tests/envs/maze

@rodrigodelazcano
Copy link
Member

LGTM! Thank you @gauthamvasan

@rodrigodelazcano rodrigodelazcano merged commit 56eb9a6 into Farama-Foundation:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Setting goal_cell in point_maze causes an error
2 participants