FWI-2719: Enable and add exemptions for recently-added checks #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainerENvVar to ignore `valueFrom`, add ClusterAdmin checks to config-full.yaml Enable and add exemptions for these checks: * automountServiceAccountToken * linuxHardening * missingNetworkPolicy * sensitiveConfigmapContent and sensitiveContainerEnvVar * clusterrolebindingClusterAdmin, rolebindingClusterAdminClusterRole, and rolebindingClusterAdminRole * clusterrolePodExecAttach, rolePodExecAttach, clusterrolebindingPodExecAttach, rolebindingClusterRolePodExecAttach, and rolebindingRolePodExecAttach Fix the `sensitiveContainerEnvVar` check to ignore sensitive environment variable names when those variables use `valueFrom` to reference an external resource. Add the `*ClusterAdmin` checks to `examples/config-full.yaml`.
Fairwinds Insights CI Report✅ No new Action Items detected! |
ivanfetch-wt
changed the title
rbren
approved these changes
Aug 31, 2022
|
I'm waiting to merge this (making these checks live for the Polaris community) until a deeper round of initial testing has completed. |
…sSuffix` functions are available in the go template, exempt the prefix `system:` instead of indifidual entries for RBAC checks (#871) * `hasPrefix` and `hasSuffix` functions are available in the go template, exempt the prefix `system:` instead of indifidual entries for RBAC checks * The RBAC checks `clusterrolebindingClusterAdmin` and `clusterrolebindingPodExecAttach` now exempt bindings that start with `system:`, instead of listing explicit strings. * The RBAC check `clusterrolePodExecAttach` now exempt ClusterRoles that start with `system:`, instead of listing explicit strings. * Update documentation to include additional Go template functions * Set the `automountServiceAccountToken` check to ignore by default
…policy:sa` exemptions also to Role and ClusterRole related RBAC checks
rbren
approved these changes
Nov 11, 2022
|
Thanks for adding all the new test cases! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also ticket 3025 which describes results testing these checks in some live environments.
Checklist
Description
What's the goal of this PR?
These checks are now enabled in the default Polaris configuration:
These checks are listed in the default configuration but remain set to
ignoreto avoid a storm of results:Fixed the
sensitiveContainerEnvVarcheck to ignore sensitive environmentvariable names when those variables use
valueFromto reference anexternal resource.
Added exemptions to RBAC related checks for names prefixed with
system:, and alsogce:podsecuritypolicy:calico-sa. This avoids chasing a growing list of exemptions as new versions of Kube adjust built-in resources.Added the
*ClusterAdminchecks toexamples/config-full.yaml.