Contract annotations for net.minecraft.util.math classes #4352
+5,435
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly; merge type annotations buttons where applicable; fix arrays not working
skycatminepokie
changed the title
Earthcomputer
requested changes
Oct 20, 2025
|
OK, that's a lot better. I went a little crazy at first xd |
|
|
|
Where? I wouldn't be surprised though, I will fix it when your PR is merged. I checked out the latest yarn, then merged your branch on top, then made my changes. This is really my first experience with working with multiple collaborative branches - it's always been just me or a random one-off change :P |
|
The git history looks fine to me, I think he missed that this PR has a dependency. It will need rebasing once my PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes trip me up sometimes, with immutability and mutability mixed in with each other. Hopefully, adding contract annotations will help.
I avoided annotating anything that returns a primitive type - that seems unnecessary and would add bloat. I also didn't annotate static methods, as they can usually be assumed to be pure.
Depends on #4351 , and has more classes to do, so I'm leaving this as a draft.