Handle multiple FabricLoaderLauncherSessionListener instances. #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the VSCode test runner will create multiple FabricLoaderLauncherSessionListener instances. We can only ever have one Knot instance so store it statically.
|
Visual Studio Code now works for running tests with these changes applied. This pull request will close #1000. |
|
How can we help getting this merged? Running mutation tests using PITest cause the same issue and this will probably fix it as well (I'm not sure how to test these changes locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the VSCode test runner will create multiple FabricLoaderLauncherSessionListener instances. We can only ever have one Knot instance so store it statically.
TODO test: