[1.20.1] backport translations feature from 1.21 #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TexBlock
changed the title
|
Thanks for this. It'll take some time to review and test, but will keep you posted. |
|
I just started an instance with this patch, and copied over my test quest data from my current 1.20.1 dev instance. It failed to start: https://gist.github.com/desht/8a78d48f2e7ebb494086310c98d3ccd1 This is of course a show-stopper... legacy data import absolutely has to work reliably. |
|
This is looking better now; my old data loaded and converted correctly. I will continue testing, thanks. |
|
What is the status of this PR? This is very helpful to support localization quests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.