Skip to content

Ban Revoke Structure #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1-alex98 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Ban Revoke Structure #96

1-alex98 wants to merge 1 commit into from

Conversation

@1-alex98
Copy link
Member

@1-alex98 1-alex98 commented Nov 1, 2018

Fixes #95

@1-alex98
Copy link
Member Author

1-alex98 commented Nov 1, 2018 •
edited
Loading

Missing correct faf-stack version

@1-alex98 1-alex98 force-pushed the feature/#95-ban-revoke-structure branch 4 times, most recently from c00f64a to f97af44 Compare November 1, 2018 22:11
@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage decreased (-0.03%) to 84.442% when pulling f97af44 on feature/#95-ban-revoke-structure into 414b82b on develop.

micheljung
micheljung requested changes Nov 6, 2018
View reviewed changes
faf-java-server-app/src/main/java/com/faforever/server/security/BanDetails.java
@JoinColumn(name = "revoke_author_id")
private User revokeAuthor;
@Column(name = "revoke_time")
private OffsetDateTime revokeTime;
Copy link
Member

@micheljung micheljung Nov 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"What would Downlord say?"

Let's see if you can figure it out ;-)

Hint: it's about the whole block, not this specific line

Copy link
Member Author

@1-alex98 1-alex98 Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea

Copy link
Member Author

@1-alex98 1-alex98 Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh format?

Copy link
Member Author

@1-alex98 1-alex98 Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soooo picky :D

@1-alex98 1-alex98 force-pushed the feature/#95-ban-revoke-structure branch from f97af44 to cddc7a3 Compare November 11, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micheljung micheljung micheljung requested changes

@Brutus5000 Brutus5000 Awaiting requested review from Brutus5000

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1-alex98 @coveralls @micheljung @Brutus5000