-
-
Notifications
You must be signed in to change notification settings - Fork 74
fix: set process working dir based on relative path of -f file too #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Why === * extends now sets the working dir of the processes in it based on the relative path of the process-compose file. * The documentation says that -f should be equvalent to using extends * However, -f does not set the workign dir of the process to match the process-compose file's path * To make the documentation consistent again, we should also set the working dir for the -f filename case. What changed === * Move the working dir copy from loadExtendProject to loadProjectFromFile Test plan === * -f and extends both set the expected working dir of the processes in my local tests
e50ae1a
to
8b0f635
Compare
|
@F1bonacc1 gentle nudge here. Are you reticent about merging this because it breaks some backward compatibility with working dirs of CLI args? |
@F1bonacc1 Just checking in again, it's been a month. Any feedback for this? |
Hi @ryantm, |
Makes sense! Can we do a breaking change version release to get this? What other mechanisms can we use to gradually move people toward this world of sanity and consistency? |
I see 3 options, I can't say I love any of them, but I am of course open for other suggestions:
There may be other options that I haven't considered... |
Why
What changed
Test plan