Define selectionOrigin #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
|
@perunt - Is this still needed? Who should review? |
Author
|
Yes, it's still valid. This PR removes this patch-package |
|
Brought this up in slack here, but I think we should:
|
Author
|
Current PR and upstream PR is updated |
|
Going to close this because we're no longer using our React Native fork. |
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR Link
Summary
It's a fix for #49. There Missing of defining of selectionOrigin in
textInputDidChangeSelectionIt was discovered in updating RN process Expensify/App#18507 (comment)
Changelog
[CATEGORY] [TYPE] - Message
Test Plan
For details on the test plan, please refer to #49