-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update App to React Native 0.72 version #18507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 20 commits
fb839b2
31a5993
aadce15
1853e3a
e317397
dc090e4
b7951d6
cc82588
00eb45d
94fffc7
4f6775d
0fb2aa0
675801f
b45c2f6
61c395b
ff1c818
4bbf36e
8c41f3c
ef3a33b
7c09b4e
20092ea
84196ee
6026a60
239def1
622e9f7
f18b635
3248140
e1cda52
50245aa
e7c0c61
5436537
0c3acdf
33bdacd
25696cd
4d42218
6a9fc44
5005579
dae067f
3e75ba2
3829399
ea2ffb2
952cad4
7b2292e
7b8b26f
058809d
f10fd80
12f60b4
2dc0e8c
043f3b7
8cc097b
4881cd4
7d40e26
2b07cf5
6c8e524
72a3520
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| gem "cocoapods", "~> 1.11.3" | ||
| # You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
| ruby ">= 2.6.10" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it will be better to set it as 3.x
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with @parasharrajat that we should get on Ruby 3 if possible. However, I suggest that we lock to a specific version of Ruby and cocoapods. The Also, why remove the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @roryabraham @parasharrajat It was removed in the last version and now the ruby version is specified in
These two commits also give us some insight about what those decisions:
Yes, I agree as well (as long Ruby 3 works, needs testing). In fact, a common problem that we have here is that some contributors do Coming from this issue, I agree we should change the instructions to tell contributors to use only |
||
|
|
||
| gem "cocoapods", "~> 1.12" | ||
| gem "fastlane", "~> 2" | ||
| gem "xcpretty", "~> 0" | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.1-all.zip | ||
| networkTimeout=10000 | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.