[Payment now] [$1000] Compose box - Suggestion list not displays when open group chat and write '@'

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: user should be signed in and have a group chat with several members

1. Open app
2. Navigate to group chat
3. Tap on the compose box
4. Write '@"

Expected Result:

Suggestion list should be displayed

Actual Result:

Nothing happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.51.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6157704_Suggestion_list_not_displayed_on_iphone_14_Pro_Max.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01597e4b673ae39722
• Upwork Job ID: 1689186963484561408
• Last Price Increase: 2023-08-09
• Automatic offers:
• WikusKriek | Contributor | 26156328

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On first character typed for iOS as '@' mention suggestions are not shown.

What is the root cause of that problem?

• The root cause is that the state is not updated yet when onSelectionChange is called.

• This is due to the fact that the state is updated in the different function and onSelectionChange is called parallel to it. This happens only on iOS for the first character typed.

• Affecting PR: Fix mentions results does not close when we change focus to first character #19334 ( This PR basically introduced the issue. )

What changes do you think we should make in order to solve the problem?

• We should wait for the state to be updated before checking if the value is empty or not.

• Changing below function

App/src/pages/home/report/ReportActionCompose.js

Lines 301 to 312 in 2e9caea

	onSelectionChange(e) {
	LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
	this.setState({selection: e.nativeEvent.selection});
	if (!this.state.value || e.nativeEvent.selection.end < 1) {
	this.resetSuggestions();
	this.shouldBlockEmojiCalc = false;
	this.shouldBlockMentionCalc = false;
	return;
	}
	this.calculateEmojiSuggestion();
	this.calculateMentionSuggestion();
	}

Updated Function Code:

• Here we are moving the this.state.value check code in the setTimeout function. This will make sure that the state is updated before we check the value. Also we are only setting the timeout if the value is empty and the OS is iOS. This will make sure that we don't have any performance issues.

onSelectionChange(e) {
    LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
    const selection = e.nativeEvent ? e.nativeEvent.selection : {};
    this.setState({selection});
    const shouldWait = this.state.value === '' && getOperatingSystem() === CONST.OS.IOS;
    const ms = shouldWait ? 10 : 0;
    setTimeout(() => {
        if (!this.state.value || selection.end < 1) {
            this.resetSuggestions();
            this.shouldBlockEmojiCalc = false;
            this.shouldBlockMentionCalc = false;
            return;
        }
        this.calculateEmojiSuggestion();
        this.calculateMentionSuggestion();
    }, ms);
}

What alternative solutions did you explore? (Optional)

• We should find why is this not happening on other platforms.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Compose box - Suggestion list not displays when open group chat and write '@'

What is the root cause of that problem?

We calculate the mentioned suggestion on onSelectionChange. But onSelectionChange is triggered before onChangeText (native behavior on IOS)

What changes do you think we should make in order to solve the problem?

We just have the same issue before. @s77rt @mollfpr Ping you here because you have context in #12854

More reference: facebook/react-native#28865

What alternative solutions did you explore? (Optional)

[conorpendergrast]

Reproduced on iOS native app, and not on OSX desktop.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01597e4b673ae39722

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)