Better handle swap immediately? #955
Open
+83
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #953 looks to be good, but i still noticed somethong:
What if code modders don't use it correctly?
According to https://github.com/EverestAPI/Resources/wiki/Making-Code-Mods#on-hooks, when hooking a coroutine with
SwapImmediately
, sometimes the method suffix will not run. However, #953 will ALWAYS run them. While nobody should be doing this, this could cause problems in the future:Actually there's no solution for this. so
This pr changes
Coroutine
to always run suffixes.still not tested, but looks good to me.