-
Notifications
You must be signed in to change notification settings - Fork 298
build: bump rust toolchain version #3910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
approved these changes
Mar 4, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3910 +/- ##
==========================================
+ Coverage 78.49% 78.54% +0.05%
==========================================
Files 767 767
Lines 97826 97772 -54
==========================================
+ Hits 76786 76794 +8
+ Misses 21040 20978 -62
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the Rust toolchain version up to a nightly channel, since rust-analyzer now only supports 1.82.0+, which means our previous version (1.82.0 nightly) is not supported.
Would prefer to bump it to the latest nightly but there are way too many Clippy lint errors already.Using a recent nightly because the other ones turned out to be buggy.Bulk of the errors are straightfoward Clippy lint fixes. I chose to pretty much fix all of them except for the ones in our forked packages (arrow2 and parquet2).