Skip to content

Conversation

kevinzwang
Copy link
Member

@kevinzwang kevinzwang commented Mar 4, 2025

Bump the Rust toolchain version up to a nightly channel, since rust-analyzer now only supports 1.82.0+, which means our previous version (1.82.0 nightly) is not supported.

Would prefer to bump it to the latest nightly but there are way too many Clippy lint errors already. Using a recent nightly because the other ones turned out to be buggy.

Bulk of the errors are straightfoward Clippy lint fixes. I chose to pretty much fix all of them except for the ones in our forked packages (arrow2 and parquet2).

@github-actions github-actions bot added the build label Mar 4, 2025
@kevinzwang kevinzwang requested review from colin-ho and jaychia March 4, 2025 23:15
@kevinzwang
Copy link
Member Author

kevinzwang commented Mar 5, 2025

Clippy holding me hostage with a million linting errors for a simple version bump

@kevinzwang kevinzwang enabled auto-merge (squash) March 5, 2025 04:29
@kevinzwang kevinzwang merged commit aa6655c into main Mar 5, 2025
49 checks passed
@kevinzwang kevinzwang deleted the kevin/bump-rust-toolchain branch March 5, 2025 04:50
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 75.89286% with 81 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (e315c21) to head (aa2c810).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-io/src/azure_blob.rs 0.00% 10 Missing ⚠️
src/daft-io/src/http.rs 0.00% 6 Missing ⚠️
src/daft-sql/src/schema.rs 0.00% 6 Missing ⚠️
src/daft-io/src/s3_like.rs 58.33% 5 Missing ⚠️
src/daft-core/src/array/ops/list.rs 82.60% 4 Missing ⚠️
src/daft-io/src/google_cloud.rs 0.00% 4 Missing ⚠️
src/daft-recordbatch/src/ops/joins/merge_join.rs 55.55% 4 Missing ⚠️
src/common/display/src/mermaid.rs 40.00% 3 Missing ⚠️
src/daft-core/src/array/ops/pairwise.rs 0.00% 3 Missing ⚠️
...daft-physical-plan/src/physical_planner/display.rs 0.00% 3 Missing ⚠️
... and 25 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3910      +/-   ##
==========================================
+ Coverage   78.49%   78.54%   +0.05%     
==========================================
  Files         767      767              
  Lines       97826    97772      -54     
==========================================
+ Hits        76786    76794       +8     
+ Misses      21040    20978      -62     
Files with missing lines Coverage Δ
daft/expressions/expressions.py 94.00% <ø> (ø)
src/common/arrow-ffi/src/lib.rs 99.23% <100.00%> (ø)
src/common/daft-config/src/lib.rs 86.25% <ø> (ø)
src/common/display/src/table_display.rs 80.89% <100.00%> (ø)
src/common/display/src/tree.rs 31.81% <100.00%> (-5.69%) ⬇️
src/common/error/src/error.rs 83.87% <100.00%> (-0.51%) ⬇️
src/common/io-config/src/python.rs 62.05% <100.00%> (+0.14%) ⬆️
src/common/io-config/src/s3.rs 62.24% <100.00%> (+0.51%) ⬆️
src/common/partitioning/src/lib.rs 6.12% <ø> (ø)
src/common/runtime/src/lib.rs 91.21% <100.00%> (+0.24%) ⬆️
... and 125 more

... and 95 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants