Skip to content

Conversation

universalmind303
Copy link
Contributor

Description

this embeds the frontend static assets in to the binary so that we don't need to worry about them at runtime.

Also some misc cleanup to remove the rust only stuff from dashboard as we'll be adding this in to the main daft wheel soon.

Sidenote:

Currently the assets are only about 4MB, we'll need to be extra cautious about adding too much dependencies to the dashboard as it could very easily bloat our binary.

Additional work (will be done in subsequent PR's)

  • rename daft_dashboard to daft-dashboard for consistency with rest of crates
  • move daft-dashboard inside src and include it in main build

Copy link
Contributor Author

@universalmind303 universalmind303 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .gitkeep is needed because the include_dir! macro is expanded BEFORE the build.rs script, so if this is removed, then the macro will error because the directory does not exist, and the build.rs has not had a chance to create it yet.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (ffa58cd) to head (2b0ef0e).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   78.48%   78.47%   -0.01%     
==========================================
  Files         769      767       -2     
  Lines       97790    97783       -7     
==========================================
- Hits        76747    76740       -7     
  Misses      21043    21043              
Files with missing lines Coverage Δ
daft_dashboard/src/lib.rs 0.00% <ø> (ø)

... and 16 files with indirect coverage changes

@universalmind303 universalmind303 merged commit 09167cd into Eventual-Inc:main Mar 4, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants