chore: make dashboard assets part of build process. #3905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this embeds the frontend static assets in to the binary so that we don't need to worry about them at runtime.
Also some misc cleanup to remove the rust only stuff from dashboard as we'll be adding this in to the main daft wheel soon.
Sidenote:
Currently the assets are only about 4MB, we'll need to be extra cautious about adding too much dependencies to the dashboard as it could very easily bloat our binary.
Additional work (will be done in subsequent PR's)
daft_dashboard
todaft-dashboard
for consistency with rest of cratesdaft-dashboard
insidesrc
and include it in main build