Skip to content

Conversation

universalmind303
Copy link
Contributor

closes #3891

@github-actions github-actions bot added the fix label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (567ae9a) to head (c73a38f).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3892      +/-   ##
==========================================
- Coverage   78.46%   76.72%   -1.74%     
==========================================
  Files         767      769       +2     
  Lines       97108   100130    +3022     
==========================================
+ Hits        76193    76829     +636     
- Misses      20915    23301    +2386     
Files with missing lines Coverage Δ
src/daft-core/src/array/ops/map.rs 87.87% <100.00%> (+0.37%) ⬆️

... and 40 files with indirect coverage changes

@universalmind303
Copy link
Contributor Author

pretty sure the llvm-cov is wrong here.

The only file changed as increased coverage, but the overall coverage went down?

image

@universalmind303 universalmind303 merged commit acf5e22 into Eventual-Inc:main Mar 4, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map.get with no rows throws error, while struct.get does not
2 participants