Skip to content

Conversation

f4t4nt
Copy link
Contributor

@f4t4nt f4t4nt commented Mar 1, 2025

This PR adds documentation for the functions module and refactors several functions from expressions to the functions module. Key changes:

  • Moves list_, struct, and coalesce from expressions to the dedicated functions module
  • Adds new functions.rst file with structured documentation
  • Organizes functions into logical categories (sequence, general, constructor)

@f4t4nt f4t4nt requested a review from colin-ho March 1, 2025 00:20
@github-actions github-actions bot added the docs label Mar 1, 2025
@f4t4nt f4t4nt force-pushed the docs/functions-documentation branch from 9253791 to 4b1dda6 Compare March 1, 2025 02:16
@f4t4nt
Copy link
Contributor Author

f4t4nt commented Mar 1, 2025

I didn't move coalesce, list, struct to functions for now as that seems more involved (ie have to move things around on the rust side too?). Maybe that can be another PR?

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (567ae9a) to head (860faad).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3880      +/-   ##
==========================================
- Coverage   78.46%   77.78%   -0.69%     
==========================================
  Files         767      769       +2     
  Lines       97108    97838     +730     
==========================================
- Hits        76193    76100      -93     
- Misses      20915    21738     +823     

see 39 files with indirect coverage changes

@f4t4nt f4t4nt requested a review from ccmao1130 March 3, 2025 19:12
@f4t4nt f4t4nt marked this pull request as ready for review March 4, 2025 01:54
@f4t4nt f4t4nt merged commit ffa58cd into main Mar 4, 2025
50 checks passed
@f4t4nt f4t4nt deleted the docs/functions-documentation branch March 4, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants