Skip to content

Conversation

universalmind303
Copy link
Contributor

tiny PR to consolidate a bunch of files with a single test case into a file with multiple cases.

@universalmind303 universalmind303 changed the title chore: consolidate multiple files in tests/connect chore(connect): consolidate multiple files in tests/connect Jan 13, 2025
@github-actions github-actions bot added the chore label Jan 13, 2025
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #3676 will improve performances by 61.42%

Comparing universalmind303:connect-consolidation (564cae7) with main (c932ec9)

Summary

⚡ 2 improvements
✅ 25 untouched benchmarks

Benchmarks breakdown

Benchmark main universalmind303:connect-consolidation Change
test_iter_rows_first_row[100 Small Files] 276.8 ms 171.5 ms +61.42%
test_show[100 Small Files] 24 ms 16.1 ms +48.81%

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (c932ec9) to head (564cae7).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3676      +/-   ##
==========================================
- Coverage   78.06%   77.25%   -0.82%     
==========================================
  Files         728      728              
  Lines       89967    92179    +2212     
==========================================
+ Hits        70236    71214     +978     
- Misses      19731    20965    +1234     

see 21 files with indirect coverage changes

@universalmind303 universalmind303 merged commit feab49a into Eventual-Inc:main Jan 14, 2025
42 checks passed
@universalmind303 universalmind303 deleted the connect-consolidation branch January 23, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants