Skip to content

Conversation

@gavinr-maps
Copy link
Contributor

@patrickarlt
Copy link
Contributor

@gavinr-maps Do you think it would be possible to come up with a unit test that would reflect this fix?

@gavinr-maps
Copy link
Contributor Author

@patrickarlt since this is in createTile which is called from elsewhere in Leaflet, I'm not sure how to test this. I do not see any other unit tests for this createTile function either. Could you give me some guidance?

@gavinr-maps
Copy link
Contributor Author

@patrickarlt here is the replication case:

  1. Current Behavior:
    Open https://codepen.io/gavinr/pen/gbpjJMj?editors=1010

    • Expected: the imagery layer (black and white layer) should show on load
    • Actual: the imagery layer (black and white layer) does not show on load. It does show if you zoom out then zoom back in.
  2. Changes from this PR:
    Open https://codepen.io/gavinr/pen/PwqBvBL?editors=1010

    • Expected: the imagery layer (black and white layer) should show on load
    • Actual: the imagery layer (black and white layer) should shows on load

@gavinr-maps gavinr-maps marked this pull request as ready for review June 17, 2025 14:19
@gavinr-maps gavinr-maps requested a review from patrickarlt June 17, 2025 14:19
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinr-maps gavinr-maps merged commit 202e125 into master Jun 24, 2025
18 checks passed
@gavinr-maps gavinr-maps deleted the 1384-lod branch June 24, 2025 12:45
gavinr-maps added a commit to gavinr-maps/esri-leaflet that referenced this pull request Aug 6, 2025
gavinr-maps added a commit that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants