This repository was archived by the owner on Oct 6, 2023. It is now read-only.
Feature: extend L.esri.Cluster.featureLayer too #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
commented
Sep 8, 2018
src/ClusterFeatureLayerHook.js
Outdated
| } | ||
| var oldOnAdd = L.Util.bind(this.onAdd, this); | ||
| var oldUnbindPopup = L.Util.bind(this.unbindPopup, this); | ||
| var oldOnRemove = L.Util.bind(this.onRemove, this); |
Contributor
Author
There was a problem hiding this comment.
literally the only difference between this new hook and the existing one is to not bind this.createNewLayer here.
jgravois
force-pushed
the
feat/cluster
branch
from
7554332 to
b1679eb
Compare
Contributor
Author
|
yolo |
jgravois
commented
Jun 18, 2020
Comment on lines
+14
to
+16
| "esri-leaflet": "^2.2.3", | ||
| "leaflet": "^1.3.4", | ||
| "leaflet-shape-markers": "^1.0.6" |
Contributor
Author
There was a problem hiding this comment.
as discussed in #152, loose peerDependencies would be a better idea.
Closed
This was referenced Jun 19, 2020
Closed
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Esri/esri-leaflet-cluster#18
i had a little time today so i came up with a rough cut of how this plugin could be extended to ensure that
L.esri.Cluster.featureLayerwill draw the symbology defined in a service any time a feature isn't clustered too.the check for
L.esri.Clusterfeels like a hack and i don't think it would work with Webpack, but using ES6 to importClusteras a dependency doesn't seem like the right thing either.