Skip to content

#789 Catch StackOverflowError and add hint for enabling references #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

#789 Catch StackOverflowError and add hint for enabling references #790

merged 1 commit into from
Nov 16, 2020

Conversation

theigl
Copy link
Collaborator

@theigl theigl commented Nov 6, 2020

This PR catches StackOverflowError thrown by FieldSerializer and adds hint about enabling references to the error message.

Resolves #789.

@theigl theigl self-assigned this Nov 6, 2020
@theigl theigl mentioned this pull request Nov 6, 2020
Closed
@theigl theigl force-pushed the 789-stackoverflow-message branch from 78a3a14 to 4afc56c Compare November 8, 2020 14:03
@theigl theigl force-pushed the 789-stackoverflow-message branch from 4afc56c to 7cedf69 Compare November 8, 2020 14:18
@theigl theigl merged commit 04e0e90 into EsotericSoftware:master Nov 16, 2020
@theigl theigl deleted the 789-stackoverflow-message branch November 16, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theigl theigl

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stackoverflow in FieldSerializer on circular references.
1 participant
@theigl