Fix nondeterministic behavior in testConcurrentHashMapKeySetViewCopy() #1227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a nondeterministic test failure in
DefaultSerializersTest.testConcurrentHashMapKeySetViewCopy()within both themainandmain-versionedmodules when running with NonDex.Problem
The nondeterminism arises from using
assertEquals(set.iterator().next(), copy.iterator().next()), which depends on the iteration order of aConcurrentHashMap.KeySetView.Since
ConcurrentHashMapdoes not guarantee a stable iteration order, the first element returned byiterator().next()can vary between runs, causing the test to fail under NonDex.Reproduce Test
To reproduce the failure, run NonDex on both the
mainandmain-versionedmodules using the following commands:The Fix
Instead of comparing the first element returned by each iterator — which could differ due to the nondeterministic iteration order of
ConcurrentHashMap— the test now verifies that both collections contain the same elements.This approach ensures logical equality without relying on iteration order, effectively confirming that both sets represent the same data regardless of internal ordering.