Use the compile_commands implementation from the monolithic rule in the per_file rule #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Currently, we use a different, inferior implementation for generating compile_commands.json in the
pre_filerule.We should use the same as in the monolithic rule. This would prevent us from having to maintain both rules simultaneously.
What:
Replaces the
compile_commands.jsongenerating implementation in thepre_filerule.Fixes the unittest for compile_commands, the per_file
compile_commands.jsonlocation changedAddresses:
None