[mlir] SCF reverse-mode derivatives #2348
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangoraw
reviewed
Jun 18, 2025
| auto term = oBB.getTerminator(); | ||
|
|
||
| for (auto &&[arg, operand] : | ||
| llvm::zip_equal(incomingGradients, term->getOperands())) { |
There was a problem hiding this comment.
IIUC, incomingGradients can be smaller than term->getOperands() if at least one result is inactive
There was a problem hiding this comment.
Good catch, will fix and add a test
* fix enzyme-to-memref
wsmoses
reviewed
Jul 7, 2025
| MGradientUtilsReverse *gutils) const { | ||
| auto ifOp = cast<scf::IfOp>(op); | ||
|
|
||
| Operation *newOp = gutils->getNewFromOriginal(op); |
There was a problem hiding this comment.
Nit but if all the inner operations and resulting values are inactive we can skip storing this
wsmoses
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.