Support empty response for Completions and ChatCompletions API #3309
+42
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where evaluation will fail if any of the
text
/content
responses isNone
from the API under test.This happens because the
parse_generations
functions say that they returnList[str]
, but will actually return alist[Optional[str]]
when the response from the API isNone
.This error scenario is more likely with reasoning models.
Some frameworks put the reasoning tokens in a different field, and without a high enough
max_gen_toks
the entire token budget will be spent on reasoning tokens. This leaves thetext
/content
field asNone
.I've hit this error scenario when testing
gpt-oss-20b
on vLLM with thegsm8k_cot_llama
dataset.