[FIX] Initial code to disable multi-proc for stderr #3106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi! Thanks for the PR! This looks good overall. I made some slight changes to keep parity with mp-bootstrapping (seed and return type) and took the opportunity to add some docs while I was at it. Good to merge! |
baberabb
approved these changes
Jul 4, 2025
|
Just though of: could be faster with a list comp, but not sure of the memory implications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax doesn't like multi-threading. When using the eval harness during some jax code, the multithreading causes deadlocks blocking everything.
This PR just adds an optional flag to disable multi-threading, specifically in the
stderrcalculation inmetrics.pysince that seems to be the main culprit.The idea is that JAX users can simply disable pass this flag and disable all MP. This will also have to be documented somewhere, I have no idea where.