Taproot tests using python bindings for secp256k1-zkp #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
changed the title
This change was not reflected in elements
This merge contains code originally contributed by me, Dmitry Petukhov, into python-bitcointx (https://github.com/Simplexum/python-bitcointx) and python-elementstx (https://github.com/Simplexum/python-elementstx) projects. The code was originally submitted to these projects under GNU Lesser General Public License. As the author of the code in question, I thereby give my permission to use, modify and distribute this code under MIT software license.
Member
|
Now that #1002 is merged I am going to close this. For the avoidance of doubt, this is a no-merge because it includes Python bindings to libsecp256k1-zkp which put additional system requirements on build machines, and which are forked off of a 3rd-party (Dmitry)'s project, which would mean an ongoing maintanance/syncing requirem.nt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1002 only implements tests for taproot sighash that spend from non-confidential txouts. Since, we do not yet have wallet support, it is not possible to use regular blinding rpcs to spend from confidential txouts. This adds support for python test framework for creating blinding transactions using bindings from @dgpv.
@apoelstra suggested that we should not be merging these bindings here because 1) they will create platform/architecture dependency for tests. and 2) the bindings rely on .so file and we do not want to touch the build system to enforce this in CI.
Regardless, this PR can aid in the review of #1002 or can help writing blinding/CT logic in the future too. The test has instructions on how to run it.
The code quality of the test is not the best, but if we want to merge this I can work on improving the test.
Marking as draft because we don't expect these tests to be merged.