Add clearable to el-input #8509
Conversation
| </script> | ||
| ``` | ||
| ::: | ||
|
|
There was a problem hiding this comment.
Please also add clearable in the Input Attribute table.
There was a problem hiding this comment.
Any order preference? Should I add it to the end of the attribute list?
There was a problem hiding this comment.
Actually, I'm thinking it would be nice to have attribute / slot / event lists ordered alphabetically (at least for en-US). Would you support a PR for this?
There was a problem hiding this comment.
I think the order of items is insignificant now, you can append to the list.
Alphabetical order may not be a good idea. I think it's better to group items by their features.
For example: prefix-icon, suffix-icon should stay together.
There was a problem hiding this comment.
That makes sense. I appended it to the list.
packages/input/src/input.vue
Outdated
| clear() { | ||
| this.$emit('input', ''); | ||
| this.setCurrentValue(''); | ||
| this.focus(); |
There was a problem hiding this comment.
Hi, everything looks good to me, except that after clearing the input, the change event should trigger. Here we should add
this.$emit('change', '');
examples/docs/en-US/input.md
Outdated
| <el-input | ||
| placeholder="Please input" | ||
| v-model="input10" | ||
| :clearable="true"> |
There was a problem hiding this comment.
I prefer clearable shorthand here.
|
@Leopoldthecoder Hey, I see this was released in the new version and it's live on |
|
@lbogdan Sorry I forgot about that. Will add it soon. |
Adds
clearableprop to el-input. When set totrue, if the input is not empty and it's focused or hovered, it shows a clear icon, which, when clicked, clears the input.Resolves #8469.
devbranch.