Skip to content

Conversation

island205
Copy link
Contributor

@island205 island205 commented Jan 18, 2019

close #13803

also fix el-autocomplete when type is textarea

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Jan 18, 2019

Deploy preview for element ready!

Built with commit 05811bd

https://deploy-preview-14143--element.netlify.com

@island205 island205 requested review from iamkun and ziyoung January 18, 2019 07:11
@@ -149,7 +149,10 @@
},
watch: {
suggestionVisible(val) {
this.broadcast('ElAutocompleteSuggestions', 'visible', [val, this.$refs.input.$refs.input.offsetWidth]);
let input = this.$refs.input.$refs.input || this.$refs.input.$refs.textarea;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我记得可以吧这一行改成一个方法调用。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看看

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autocomplete 有必要支持 type="textarea" 吗?设置成 textarea 时样式都乱掉了 https://jsfiddle.net/0ca3q5xj/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type 和 autocomplete 作为组合属性,用户可能会用到,至少避免用户用的时候坏掉吧?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants