Skip to content

TimePicker: explicit declare box-sizing: content-box #13347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

TimePicker: explicit declare box-sizing: content-box #13347

merged 1 commit into from
Nov 9, 2018

Conversation

PanJiaChen
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Many projects will increase the following css globally.

*,
*:before,
*:after {
  box-sizing: inherit;
}

Such as minireset, bootstrap Or article.

But time-pick hs a display bug, because it will inherit el-date-range-picker__time-header attr.

image

Online demo

@PanJiaChen PanJiaChen mentioned this pull request Nov 8, 2018
Closed
@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit f922b01

https://deploy-preview-13347--element.netlify.com

@ziyoung ziyoung merged commit fb4ba16 into ElemeFE:dev Nov 9, 2018
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
@PanJiaChen
TimePicker: explicit declare box-sizing: content-box (ElemeFE#13347)
36d1f0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PanJiaChen @element-bot @ziyoung