Skip to content

InputNumber: add select method #13286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Nov 5, 2018
Merged

InputNumber: add select method #13286

merged 2 commits into from Nov 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2018

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Description

Adds select method to InputNumber, analogous to Input. Currently it is possible to use inputNumberComponent.$refs.input.select() but this is internal details of the component that may change. So this PR introduces public API for selecting text in the component.

Also added missing test for select method in Input.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit d38d263

https://deploy-preview-13286--element.netlify.com

@ziyoung ziyoung merged commit 9d09d0d into ElemeFE:dev Nov 5, 2018
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
* Input: add test for `select` method

* InputNumber: add `select` method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants