Skip to content

TableColumn: add prop for renderCell like renderHeader #13209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

isnifer
Copy link
Contributor

@isnifer isnifer commented Oct 29, 2018

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Description

This PR brings the ability to set renderCell method outside a TableHeader component.
It works like a charm :)

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit b80673b

https://deploy-preview-13209--element.netlify.com

@ziyoung
Copy link
Contributor

ziyoung commented Oct 30, 2018

@isnifer we recommend user slot rather than render-function. FYI: #13012 (comment)

For some columns like index or expand column, you are not allowed to set render-cell attribute. If you want to custom cell content, use scoped slot.

@ziyoung ziyoung closed this Oct 30, 2018
@isnifer
Copy link
Contributor Author

isnifer commented Oct 30, 2018

Ok, scoped slot just does not work 👍

@panicake
Copy link

panicake commented Jun 4, 2019

I agree with adding renderCell props for table column, because I want to use jsx in vue component sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants