Skip to content

Table: Adds header rendering slot #13012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 26, 2018
Merged

Table: Adds header rendering slot #13012

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f70b08e
Table: Adds header rendering slot
ivanseidel Oct 10, 2018
8234954
Add translation to spanish
ivanseidel Oct 17, 2018
925cacd
Include render-header deprecation warning
ivanseidel Oct 17, 2018
991ef98
Add chinese translation and scoped slot description at bottom
ivanseidel Oct 20, 2018
591b8c0
Fix documentation and warnings. Fix custom-header docs
ivanseidel Oct 24, 2018
c8bf9e5
Fix redundant columns and cleanup example
ivanseidel Oct 24, 2018
022fce1
Prevent scopedSlot from working on selection column
ivanseidel Oct 24, 2018
9bd516a
Typo
ivanseidel Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/table/src/table-column.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,11 @@ export default {
}
});

// Deprecation warning for renderHeader property
if (this.renderHeader) {
console.warn('[Element Warn][Table Column]\'render-header\' property will be deprecated in next major version. please use scoped-slot \'header\' instead.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find render-header is widely used. Maybe we can't deprecate this attribute in next major version. We should give users enough time to upgrade.
A potential warning info is like this:

Comparing to render-header, scoped-slot header is easier to use. We recommend users to use scoped-slot header.

}

this.columnConfig = column;

let renderCell = column.renderCell;
Expand Down