Skip to content

Radio: support switching radio with keyborard in ff. Fixes #8198 #11325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2018
Merged

Radio: support switching radio with keyborard in ff. Fixes #8198 #11325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec9d242
Docs: fix docs of Tab-pane
jikkai May 24, 2018
22461fe
Radio: support switching radio with keyborard in ff. Fixes #8198
jikkai May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/docs/en-US/tabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@ Only card type Tabs support addable & closeable.
| disabled | whether Tab is disabled | boolean | — | false |
| name | identifier corresponding to the activeName of Tabs, representing the alias of the tab-pane | string | — | ordinal number of the tab-pane in the sequence, e.g. the first tab-pane is '1' |
| closable | whether Tab is closable | boolean | — | false |
| lazy | whether Tab is lazy to render | boolean | — | false |
| lazy | whether Tab is lazily rendered | boolean | — | false |
2 changes: 1 addition & 1 deletion examples/docs/es/tabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@ Solo las pestañas de tipo tarjeta soportan adición y cierre.
| disabled | si la Tabulación está deshabilitada | boolean | — | false |
| name | identificador correspondiente al activeName de la Tabulación, representando el alias del tab-pane | string | — | número ordinal del tab-pane en la secuencia, p.ej el primer tab-pane de pestañas es '1' |
| closable | si el Tab es cerrable | boolean | — | false |
| lazy | whether Tab is lazy to render | boolean | — | false |
| lazy | whether Tab is lazily rendered | boolean | — | false |
4 changes: 4 additions & 0 deletions packages/radio/src/radio-group.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@
e.preventDefault();
if (index === 0) {
roleRadios[length - 1].click();
roleRadios[length - 1].focus();
} else {
roleRadios[index - 1].click();
roleRadios[index - 1].focus();
}
break;
case keyCode.RIGHT:
Expand All @@ -84,8 +86,10 @@
e.stopPropagation();
e.preventDefault();
roleRadios[0].click();
roleRadios[0].focus();
} else {
roleRadios[index + 1].click();
roleRadios[index + 1].focus();
}
break;
default:
Expand Down
2 changes: 1 addition & 1 deletion types/tab-pane.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ export declare class ElTabPane extends ElementUIComponent {
/** Whether Tab is closable */
closable: boolean

/** Whether Tab is lazy to render */
/** Whether Tab is lazily rendered */
lazy: boolean
}