Skip to content

SourceID should be uint32 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SourceID should be uint32 #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d718c8
SourceID should be uint32
D3luxee Feb 1, 2022
68c7e45
FlowSample.unmarshal do not skip 3 bytes of source_id
D3luxee Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sflow/flow_sample.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const (
// FlowSample represents single flow sample
type FlowSample struct {
SequenceNo uint32 // Incremented with each flow sample
SourceID byte // sfSourceID
SourceID uint32 // sfSourceID
SamplingRate uint32 // sfPacketSamplingRate
SamplePool uint32 // Total number of packets that could have been sampled
Drops uint32 // Number of times a packet was dropped due to lack of resources
Expand Down Expand Up @@ -93,8 +93,6 @@ func (fs *FlowSample) unmarshal(r io.ReadSeeker) error {
return err
}

r.Seek(3, 1) // skip counter sample decoding

if err = read(r, &fs.SamplingRate); err != nil {
return err
}
Expand Down