Skip to content

Conversation

JBrenesSimpat
Copy link
Contributor

@JBrenesSimpat JBrenesSimpat commented Aug 27, 2025

The change consists of placing the extension in the right place when Core and Extension have the same property (sample extends it).
The following resources were successfully compared against ODS Stage (via Swagger: https://stage.preview.ed-fi.org/v7.3/docs/swagger/index.html?urls.primaryName=Resources):

  • 'EdFi_Contact'
  • 'EdFi_Credential'
  • 'EdFi_School'
  • 'EdFi_Staff'
  • 'EdFi_StudentCteProgramAssociation'
  • 'EdFi_StudentContactAssociation'
  • 'EdFi_StudentEducationOrganizationAssociation'
  • 'EdFi_StudentSchoolAssociation'
  • 'EdFi_StudentSectionAssociation'
  • 'EdFi_Student'
  • 'EdFi_SurveyResponse'

@JBrenesSimpat JBrenesSimpat requested a review from Copilot August 27, 2025 22:10
Copilot

This comment was marked as outdated.

@JBrenesSimpat JBrenesSimpat requested a review from Copilot August 28, 2025 17:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the OpenAPI extension processing logic to correctly handle cases where core and extension schemas have the same property names. The refactoring introduces a new approach that analyzes property conflicts and redirects extension properties to their appropriate referenced schemas when conflicts occur.

Key changes include:

  • Introduction of sophisticated property conflict detection and resolution logic
  • Addition of multiple helper methods to handle complex extension scenarios
  • Enhanced validation and error handling for extension schema processing
  • Backward compatibility preservation for simple extension formats

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
OpenApiDocument.cs Major refactoring of extension processing with new conflict resolution logic and helper methods
OpenApiDocumentTests.cs New test suite to verify backward compatibility and refactored functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JBrenesSimpat JBrenesSimpat marked this pull request as ready for review August 29, 2025 22:36
@JBrenesSimpat JBrenesSimpat force-pushed the DMS-753 branch 2 times, most recently from 7795274 to ea9e4fa Compare September 2, 2025 22:12
@bradbanister bradbanister merged commit 196bdfc into main Sep 5, 2025
40 checks passed
@bradbanister bradbanister deleted the DMS-753 branch September 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants