error: ‘_FillValue’ undeclared (first use in this function); did you mean ‘NC_FillValue’?

[cponder]

I'm building on the Vista cluster using the gnu compilers. I see this error

/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2433:56: error: ‘_FillValue’ undeclared (first use in this function); did you mean ‘NC_FillValue’?
 2433 |                     ierr = nc_put_att(file->fh, varid, _FillValue, xtype, 1, fill_valuep);
      |                                                        ^~~~~~~~~~
      |                                                        NC_FillValue
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2433:56: note: each undeclared identifier is reported only once for each function it appears in
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c: In function ‘PIOc_inq_var_fill’:
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2577:52: error: ‘_FillValue’ undeclared (first use in this function); did you mean ‘NC_FillValue’?
 2577 |                 ierr = nc_get_att(file->fh, varid, _FillValue, fill_valuep);
      |                                                    ^~~~~~~~~~
      |                                                    NC_FillValue
gmake[2]: *** [src/clib/CMakeFiles/pioc.dir/build.make:219: src/clib/CMakeFiles/pioc.dir/pio_nc.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:208: src/clib/CMakeFiles/pioc.dir/all] Error 2
gmake: *** [Makefile:139: all] Error 2
ERROR: /work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c: In function  PIOc_def_var_fill :
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2433:56: error:  _FillValue  undeclared (first use in this function); did you mean  NC_FillValue ?
 2433 |                     ierr = nc_put_att(file->fh, varid, _FillValue, xtype, 1, fill_valuep);
      |                                                        ^~~~~~~~~~
      |                                                        NC_FillValue
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2433:56: note: each undeclared identifier is reported only once for each function it appears in
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c: In function  PIOc_inq_var_fill :
/work/01768/ponderc/vista/EarthWorks/2025-03-09.GCC/Source/libraries/parallelio/src/clib/pio_nc.c:2577:52: error:  _FillValue  undeclared (first use in this function); did you mean  NC_FillValue ?
 2577 |                 ierr = nc_get_att(file->fh, varid, _FillValue, fill_valuep);
      |                                                    ^~~~~~~~~~
      |                                                    NC_FillValue
gmake[2]: *** [src/clib/CMakeFiles/pioc.dir/build.make:219: src/clib/CMakeFiles/pioc.dir/pio_nc.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:208: src/clib/CMakeFiles/pioc.dir/all] Error 2
gmake: *** [Makefile:139: all] Error 2

[cponder]

I grep'd for the _FillValue and just found this declaration

./Source/components/mpas-ocean/src/gotm/extras/netcdf/Win64/3.6.3/include/netcdf.h:#define _FillValue	"_FillValue"

which doesn't do anything.
Is the usage-in-question supposed to be quoted?

[cponder]

I'm using these commands to get the sources:

git clone git@github.com:EarthWorksOrg/EarthWorks.git
cd libraries/mpi-serial
git checkout tags/MPIserial_2.5.1

[gdicker1]

I think it's a version incompatibility with some newer NetCDF versions (v4.9.3) and the version of PIO we have in EarthWorks (v2.6.3). It looks like NetCDF renamed _FillValue -> NC_FillValue somewhat recently.

It looks like you can downgrade to NetCDF v4.9.2 to get things to work (see final comment in NCAR/ParallelIO#2001). Or somehow add --enable-legacy-macros to your NetCDF v4.9.3 build (see Unidata/netcdf-c#3030).

This will eventually be fixed once CESM and EarthWorks incorporate PIO 2.6.5.

(I may be wrong; I would have also expected this issue to show up with your ESMF build if the rename to NC_FillValue caused this...)

[cponder]

Adding --enable-legacy-macros to the NetCDF-C build didn't change anything.
I *think * the problem is that, even if the NetCDF-C enables the macros, the file here isn't including any definition file, so the compiler can't expand it.

That said, I build PIO 2_6_5 against the latest versions of NetCDF etc. without any problem, it looks like the issue is that EarthWorks is trying to build it's own copy instead of using what's available. Is there a way to override this?

[gdicker1]

That said, I build PIO 2_6_5 against the latest versions of NetCDF etc. without any problem, it looks like the issue is that EarthWorks is trying to build it's own copy instead of using what's available. Is there a way to override this?

Are you still trying to build with mpi-serial? If so, I think building PIO for you is what you want (since it needs to be based on mpi-serial).

I think this is normally controlled by PIO_LIBDIR in the Tools/Makefile (in your case or within CIME). You should make sure to define PIO_INCDIR along with it.

[gdicker1]

There's been no movement on this in a while. Feel free to re-open if it become relevant again.