#871 - Added callbacks when a timer is inserted or removed #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KammutierSpule
force-pushed
the
feature/871-callbacks_on_timer_functions
branch
2 times, most recently
from
7c88a15 to
0960c2b
Compare
jwellbelove
reviewed
Jul 24, 2025
include/etl/callback_timer.h
Outdated
| ETL_DISABLE_TIMER_UPDATES; | ||
| active_list.remove(timer.id, false); | ||
| remove_callback.call_if(timer.id); | ||
| remove_callback.call_if(timer.id); |
Contributor
There was a problem hiding this comment.
Two calls to the callback?
Contributor
Author
There was a problem hiding this comment.
Thanks, Fixed, (some) Unit tests added
KammutierSpule
force-pushed
the
feature/871-callbacks_on_timer_functions
branch
from
0960c2b to
cbf0611
Compare
jwellbelove
changed the base branch from
master
to
pull-request/#1155-Added-callbacks-when-a-timer-is-inserted-or-removed
Contributor
|
Shall I not merge this until you have added all of the unit tests? |
Contributor
Author
I added a couple of tests, to different types of timers. Let me know if there is some timer type missing and if you would like to see more unit tests |
Contributor
|
The unit tests for |
jwellbelove
merged commit 5f70bef
into
ETLCPP:pull-request/#1155-Added-callbacks-when-a-timer-is-inserted-or-removed
82 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Sep 11, 2025
…rted-or-removed' of https://github.com/ETLCPP/etl into pull-request/#1155-Added-callbacks-when-a-timer-is-inserted-or-removed # Conflicts: # test/vs2022/etl.vcxproj.filters
jwellbelove
pushed a commit
that referenced
this pull request
Sep 11, 2025
…rted-or-removed' of https://github.com/ETLCPP/etl into pull-request/#1155-Added-callbacks-when-a-timer-is-inserted-or-removed
jwellbelove
pushed a commit
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #871
unit tests are missing