-
Couldn't load subscription status.
- Fork 340
Decompinit timer updates #3511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Decompinit timer updates #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Init_lnd timers to around the calls rather than for the entire subroutine, because the things at the top that may abort will then have a broken timer
…etup/clean for each DecompInit test, move the decomp_mod_clean to decompMod and use it for the decompInit tests
…re each allocate has an error code handled
But, change them a bit. Conflicts: src/main/decompInitMod.F90
Conflicts: src/main/clm_initializeMod.F90
… stuff in it when use_noio is TRUE Conflicts: src/main/clm_initializeMod.F90
Conflicts: src/main/clm_initializeMod.F90
…d initialize2 calls, add timer for the InitializeRealize subroutine in this case inside of it
…d initialize2 calls, add timer for the InitializeRealize subroutine in this case inside of it
…de that does the same thing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bfb
bit-for-bit
code health
improving internal code structure to make easier to maintain (sustainability)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Spin off some internal subroutines in decompInit to organize/modularize the code better, as well as to make it easier to test. Some changes on initialization timers, and a small bit around moving more things under use_noio for testing.
THIS REPLACES #3506 WHICH ACCIDENTALLY WENT TO MASTER!
Specific notes
Contributors other than yourself, if any: @johnmauf
CTSM Issues Fixed (include github issue #):
Fixes #3387
Some work in #3448
Fixes #3508
Fixes #3509
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: ran aux_clm on Izumi/Derecho