Skip to content

Conversation

swensosc
Copy link
Contributor

@swensosc swensosc commented Aug 7, 2025

Description of changes

move namelist parameters to parameter file. parameters moved are: baseflow_scalar, precip_repartition_nonglc_all_rain_t, precip_repartition_nonglc_all_snow_t, precip_repartition_glc_all_rain_t, precip_repartition_glc_all_snow_t

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 7, 2025

I did a quick skim over this and this looks good to me. I'll rebase this PR to go to b4b-dev, which should be fine without any trouble. Sometimes you have to rebase the branch when that's done, but I don't expect that now.

The one thing noticeably missing is an updated parameter file with the parameters moved to it.

@ekluzek ekluzek added next this should get some attention in the next week or two. Normally each Thursday SE meeting. bfb bit-for-bit usability Improve or clarify user-facing options labels Aug 7, 2025
@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Aug 7, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 7, 2025

Adding next to talk about who will shepherd this in.

@ekluzek ekluzek changed the base branch from master to b4b-dev August 7, 2025 15:14
@swensosc
Copy link
Contributor Author

swensosc commented Aug 7, 2025

parameter file location: fs/cgd/csm/inputdata/lnd/clm2/paramdata/ctsm5.3.041.Nfix_params.v13.c250221_upplim250_add_nml.nc

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 12, 2025

We talked about this and will bring it in on b4b-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit usability Improve or clarify user-facing options

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants