-
Notifications
You must be signed in to change notification settings - Fork 340
ctsm5.3.069: Add SystemTests to run subset_data and then CTSM #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Runs the subset_data point tool, then runs CTSM with the outputs.
Runs subset_data region tool to extract a six-gridcell region, then runs CTSM on the outputs.
b2c3176 to
c4604b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin and I went over this PR together:
- @samsrabin posted a few TODOs
- I posted a question that I missed during the paired review
- I am approving the PR preemptively
This was causing failure in SETUP phase when generating baselines for the SUBSETDATA SystemTests.
|
Turns out that the SUBSETDATA tests don't work when trying to generate baselines. See ESMCI/cime#4819, which fixes the problem, but now serves as a blocker for this PR. |
|
No longer blocked by CIME; bring in tag cime6.1.112. |
|
Merging into master instead of b4b-dev because this depends on CIME updates that happened in ctsm5.3.067, which won't be on b4b-dev for another two weeks. |
095e8df to
e16d273
Compare
|
Initial |
Change megan_use_gamma_sm to default false The soil moisture effect was added in ctsm5.2.020 with MEGAN2.1 and was hardcoded on. As of ctsm5.3.068 megan_use_gamma_sm became default false, which is closer to MEGAN before 2.1. Hence we made megan_use_gamma_sm default off for all CLM physics versions.
|
Description of changes
Adds SUBSETDATAPOINT and SUBSETDATAREGION tests to
aux_clm(and newsubset_datasuite). These runsubset_datafor either a point or a six-cell region, then run CTSM with the outputs.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
On 0e14784:
aux_clmtesting on Derecho;SUBSETDATAtests fail when trying to generate baseline.aux_clmtesting on IzumiFinal testing:
aux_clmtesting on Derecho (/glade/derecho/scratch/samrabin/tests_0811-170941de)aux_clmtesting on Izumi (/scratch/cluster/samrabin/tests_0811-170954iz/)