-
Notifications
You must be signed in to change notification settings - Fork 338
Add SystemTests for FATES unit/functional testing #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: b4b-dev
Are you sure you want to change the base?
Conversation
ac7aa64
to
6646095
Compare
Now unblocked as NGEET/fates#1423 came in with ctsm5.3.070. |
@samsrabin I'm wondering the status of this? I'm assuming you just don't have time to work on this right now with other priorities? Part of why I ask is that I did some work to add FATES source directories to the standard FUNIT testing. And with that I noticed that I could likely add the standard unit tests there. That would be simpler than this, which may or may not be a good thing. I'm wondering about doing the simpler solution either short term until this gets in, or possibly there might be reasons for both. This might be something to talk about with the group -- but I wanted to hear from you about where this work is at first. Thanks in advance... |
@ekluzek I think this might actually be ready to come in. I prefer this approach because it explicitly calls the FATES tools, so it tests those as well as the tests themselves. It also lets us distinguish failures in FATES tests from failures in CTSM tests. |
Awesome. Sounds great. Bringing this in sooner rather than later sounds good to me. Personally I think this could come into b4b-dev, and that might facilitate it coming in sooner... |
Description of changes
Adds FUNITFATES and FUNCTIONALFATES SystemTests, analogous to the FUNITCTSM test. These are now included in the
aux_clm
,fates
, and the newunit_tests
test suites.Specific notes
Contributors other than yourself, if any: @adrifoster
CTSM Issues Fixed: None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
./run_sys_tests -s unit_tests --skip-compare --skip-generate
passes. Checkrun_*_tests.py.log
in the test case directories.