Skip to content

Conversation

samsrabin
Copy link
Member

@samsrabin samsrabin commented Jun 12, 2025

Description of changes

Adds FUNITFATES and FUNCTIONALFATES SystemTests, analogous to the FUNITCTSM test. These are now included in the aux_clm, fates, and the new unit_tests test suites.

Specific notes

Contributors other than yourself, if any: @adrifoster

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: ./run_sys_tests -s unit_tests --skip-compare --skip-generate passes. Check run_*_tests.py.log in the test case directories.

@samsrabin samsrabin self-assigned this Jun 12, 2025
@samsrabin samsrabin added testing additions or changes to tests blocked: dependency Wait to work on this until dependency is resolved bfb bit-for-bit labels Jun 12, 2025
@samsrabin samsrabin changed the title Add SystemTest for FATES unit testing Add SystemTests for FATES unit/functional testing Jun 13, 2025
@samsrabin samsrabin force-pushed the fates-unit-tests-test branch from ac7aa64 to 6646095 Compare June 20, 2025 18:00
@samsrabin
Copy link
Member Author

Now unblocked as NGEET/fates#1423 came in with ctsm5.3.070.

@samsrabin samsrabin removed the blocked: dependency Wait to work on this until dependency is resolved label Aug 22, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 7, 2025

@samsrabin I'm wondering the status of this? I'm assuming you just don't have time to work on this right now with other priorities?

Part of why I ask is that I did some work to add FATES source directories to the standard FUNIT testing. And with that I noticed that I could likely add the standard unit tests there. That would be simpler than this, which may or may not be a good thing. I'm wondering about doing the simpler solution either short term until this gets in, or possibly there might be reasons for both.

This might be something to talk about with the group -- but I wanted to hear from you about where this work is at first.

Thanks in advance...

@samsrabin
Copy link
Member Author

@ekluzek I think this might actually be ready to come in. I prefer this approach because it explicitly calls the FATES tools, so it tests those as well as the tests themselves. It also lets us distinguish failures in FATES tests from failures in CTSM tests.

@ekluzek
Copy link
Collaborator

ekluzek commented Oct 7, 2025

@ekluzek I think this might actually be ready to come in. I prefer this approach because it explicitly calls the FATES tools, so it tests those as well as the tests themselves. It also lets us distinguish failures in FATES tests from failures in CTSM tests.

Awesome. Sounds great. Bringing this in sooner rather than later sounds good to me. Personally I think this could come into b4b-dev, and that might facilitate it coming in sooner...

@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 7, 2025
@samsrabin samsrabin changed the base branch from master to b4b-dev October 7, 2025 17:40
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit testing additions or changes to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants