Possible bugs in CNFireLi2016Mod.F90

[olyson]

The following possible bug(s) were reported by Fanwei Zeng. I won't have time until after next week to investigate this, but in the interest of getting this out there so that someone else could possibly take a look at it, I'm filing an issue. Below is verbatim from Fanwei:

[lifang0209]

Hi Fanwei,

(1) Thanks for pointing out the bug. You are correct. cos(3min(60._r8,abs(grc%latdeg(g)))) should be changed to cos(pi/180._r83*min(60._r8,abs(grc%latdeg(g)))) in CNFireLi2016Mod.F90.
(2) In PM1997, it's cloud/cloud-ground=4.16+2.16cos(3lat), so we could derive that cloud-groud/total=1/(5.16+2.16cos(3lat)). forc_lnfm in CLM is the total lightning. Therefore, the default code is correct. It's not a bug in CLM or typo in Li12.

Best,
Fang

[fwzeng]

Hi Fang,

Thanks for the reply! We have fixed the bug, and will keep the code about lightning fraction as it is. Thanks for the explanation!

Best,
Fanwei

[olyson]

I have a simulation in the queue to assess the impact of this.

[olyson]

Here are diagnostics from a run branched from a historical control at year 1989:

http://webext.cgd.ucar.edu/I20TR/clm50_cesm20R_2deg_GSWP3V1_issue780_hist/lnd/clm50_cesm20R_2deg_GSWP3V1_issue780_hist.1995_2014-clm50_cesm20R_2deg_GSWP3V1_hist.1995_2014/setsIndex.html

The differences look small to me.

[fwzeng]

Thanks Keith for assessing the impact! It's great to hear that the impact is small.

[dlawrenncar]

Hey Keith, It looks like the timeseries mostly didn't run (Set 6 and only the differences are shown in Set 1). If possible, I'd like to be able to see the full timeseries. I did notice that the carbon emissions are different by order 1PgC/yr in some years, which isn't 0, but I would like to assess how big this impact is relative to the mean. I could resort to looking at other diagnostics sets if the issue with these timeseries is something specific to this run. So, only redo if easy or if it is indication of something more generally going wrong with diagnostics package. Dave

…

On Wed, Aug 14, 2019 at 8:29 AM Keith Oleson ***@***.***> wrote: Here are diagnostics from a run branched from a historical control at year 1989: http://webext.cgd.ucar.edu/I20TR/clm50_cesm20R_2deg_GSWP3V1_issue780_hist/lnd/clm50_cesm20R_2deg_GSWP3V1_issue780_hist.1995_2014-clm50_cesm20R_2deg_GSWP3V1_hist.1995_2014/setsIndex.html The differences look small to me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#780>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFABYVCZWNZUAWJCEIAJXLTQEQJF5ANCNFSM4IJAVBSA> .

[olyson]

I see what's wrong, rerunning now.

[olyson]

Ok, they are up now.