Add azimuth and incidence angle to shr_orb_mod #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swensosc - can you clarify in the PR if this is expected to be bit-for-bit and what testing you did. I am not sure why the sripts regression tests are failing for this. @fischer, @JEdwards - can you please look into the failure of the github actions scripts regression tests. It looks like its not finding the testlist. |
Collaborator
|
I'm looking into the test failures. Not sure what's going on yet. |
Collaborator
|
@swensosc I've fixed the github actions scripts regression tests. So if you merge main into your PR, the checks should pass. |
merge with main to get test fix
Contributor
|
What is the current status of this PR? Should it be merged or closed without merging? |
Contributor
Author
|
I do not know of a reason why it should be closed; I think it should be
merged.
…On Mon, Apr 4, 2022 at 3:07 PM Jim Edwards ***@***.***> wrote:
What is the current status of this PR? Should it be merged or closed
without merging?
—
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGRN57BIZO2BDRJGYJFA5WLVDNKYZANCNFSM5EMXZ2IQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@fischer-ncar @mvertens any reason not to merge this now? |
jedwards4b
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two routines to shr_orb_mod to enable calculation of azimuth angle and local incidence angle.
This is needed for the CTSM hillslope model.
Fixes #10