Modify get_random() #677
Merged
Modify get_random() #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@val213: no appropriate reviewer found, use |
yuyi2439
reviewed
Mar 29, 2024
user/dadk/config/dog_0_1_0.dadk
Outdated
| @@ -5,7 +5,7 @@ | |||
| "rust_target": null, | |||
| "task_type": { | |||
| "BuildFromSource": { | |||
| "Git": { | |||
| "Git": { | |||
There was a problem hiding this comment.
之前把编译源修改回本地测试了，最后改回去的时候没注意缩进的问题。已在最新的push中修复
|
@dragonosbot author |
dragonosbot
added
S-等待作者修改
fslongjin
reviewed
Mar 31, 2024
kernel/src/syscall/misc.rs
Outdated
| @@ -75,8 +76,11 @@ impl Syscall { | |||
| let mut ret = Vec::new(); | |||
| let mut count = 0; | |||
| while count < len { | |||
| //对len-count的长度进行判断，remain_len小于4则循环次数和remain_len相等 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在原来的实现中，代码尝试将32位随机数（rand()）分解为4个字节，并且每个循环中生成4个字节，然后推入ret向量。如果len是1，那么这个循环会产生4个额外不需要的字节，这可能是导致之前提到的错误的原因。 #675
第二种实现则简单地每次生成一个随机字节（rand() as u8），并直接推入ret向量，只有当count小于len时才继续循环。这样，无论len是多少，它都会生成正好len个字节的随机数。