generic unchangeable "Web site" label for some home screen shortcuts

[lmamane]

Reproduction instructions:

• Open URL https://auth.bluecorner.be/login or https://github.com/
• Click on "three stacked dots" menu
• Click "Add to Home screen"

Expected result:

• intermediate dialog that proposes as label for the shortcut the title of the web page, but allows one to change the label
• after clicking "add" on the intermediate dialog, get final dialog (which may be from my launcher and not from Mull) with text "touch and hold the widget to move it around the home screen" and "cancel" and "Add to home screen" buttons.

Actual result:

• no intermediate dialog, one gets directly the final dialog

Compare with many other websites, such as https://www.foo.be, https://www.debian.org, https://divestos.org where one gets the expected result.

[SkewedZeppelin]

are you able to reproduce this with upstream/official Firefox?

[lmamane]

F-Droid does not contain an app called "Firefox".

[SkewedZeppelin]

this is intended behavior

in the past it'd say "add to home screen" for adding a website and "install" for adding a PWA, but Mozilla merged them both to say "add to home screen"

when it is a PWA I guess they decided that you shouldn't be able to rename it
so this is indeed an upstream issue you can report to them instead

[lmamane]

That's particularly unfortunate when the PWA does not give a title, and Firefox/Fennec/Mull replaces that with a generic "Web site".

[SkewedZeppelin]

Fallback string is here fwiw
https://searchfox.org/mozilla-central/search?q=mozac_feature_pwa_default_shortcut_label&path=&case=false&regexp=false

I can't repro the fallback label on github.com however

[lmamane]

Reported upstream as https://bugzilla.mozilla.org/1908588
I reproduced on F-Droid's "Fennec" app whose description says it is actually Fenix.

I can't repro the fallback label on github.com however

Yes, you are right, with github.com one gets the label "GitHub", my bug report was not the most well written on that point.