feat: support python 3.14 #1337
Open
+94
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onerandomusername
changed the title
onerandomusername
requested review from
shiftinv and
Snipy7374
and removed request for
shiftinv
shiftinv
added
t: meta
onerandomusername
force-pushed
the
feat/support-py314
branch
4 times, most recently
from
1a0d1f6 to
c538624
Compare
8 tasks
onerandomusername
force-pushed
the
feat/support-py314
branch
from
c538624 to
9bcfa83
Compare
shiftinv
reviewed
Sep 7, 2025
Comment on lines
-171
to
185
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| os: ["windows-latest", "ubuntu-latest", "macos-latest"] | ||
| experimental: [false] | ||
| include: | ||
| - python-version: '3.14.0-alpha - 3.14' | ||
| experimental: true | ||
| os: "ubuntu-latest" | ||
| - python-version: '3.14.0-alpha - 3.14' | ||
| experimental: true | ||
| os: "windows-latest" | ||
| - python-version: '3.14.0-alpha - 3.14' | ||
| experimental: true | ||
| os: "macos-latest" | ||
| fail-fast: true |
There was a problem hiding this comment.
This would also work:
strategy:
matrix:
python:
- version: "3.8"
- version: "3.9"
- version: "3.10"
- version: "3.11"
- version: "3.12"
- version: "3.13"
- version: "3.14"
experimental: true
os: ["windows-latest", "ubuntu-latest", "macos-latest"]
fail-fast: true(replacing .python-version with .python.version and .experimental with .python.experimental below)
| try: | ||
| return asyncio.get_running_loop() | ||
| except RuntimeError: | ||
| return asyncio.new_event_loop() |
There was a problem hiding this comment.
Suggested change
| return asyncio.new_event_loop() | |
| asyncio.set_event_loop(loop := asyncio.new_event_loop()) | |
| return loop |
(see https://github.com/python/cpython/blob/v3.12.11/Lib/asyncio/events.py#L699)
| @@ -355,7 +355,7 @@ def before_invoke(self, coro: CFT) -> CFT: | |||
| TypeError | |||
| The coroutine passed is not actually a coroutine. | |||
| """ | |||
| if not asyncio.iscoroutinefunction(coro): | |||
| if not disnake.utils.iscoroutinefunction(coro): | |||
There was a problem hiding this comment.
Suggested change
| if not disnake.utils.iscoroutinefunction(coro): | |
| if not iscoroutinefunction(coro): |
Comment on lines
-510
to
+511
| finally: | ||
| except Exception: |
There was a problem hiding this comment.
this changes this method's behavior
| @@ -123,9 +123,9 @@ async def _call_external_error_handlers( | |||
| if local is not None: | |||
| stop_propagation = await local(inter, error) | |||
| # User has an option to cancel the global error handler by returning True | |||
| finally: | |||
| except Exception: | |||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", DeprecationWarning) | ||
| self.loop: asyncio.AbstractEventLoop = asyncio.get_event_loop() | ||
| self.loop: asyncio.AbstractEventLoop = utils.get_event_loop() |
There was a problem hiding this comment.
Similar issue here, docstring still mentions asyncio.get_event_loop.
Comment on lines
200
to
-204
| except Exception: | ||
| _log.exception("An error occurred while stopping the gateway. Ignoring.") | ||
| return | ||
| finally: | ||
| self.stop() | ||
| return # noqa: B012 |
There was a problem hiding this comment.
This also changes behavior, continuing to heartbeat after closing the ws.
As noted in the PEP and B012, return in finally can swallow exceptions (in this case only BaseExceptions), which I would argue is fine here; the thread is at the end of its lifecycle anyway.
| @@ -1,5 +1,6 @@ | |||
| # SPDX-License-Identifier: MIT | |||
|
|
|||
|
|
|||
Comment on lines
-581
to
+582
| else: | ||
| _log.info("Probe found codec=%s, bitrate=%s", codec, bitrate) | ||
| finally: | ||
| return codec, bitrate # noqa: B012 | ||
| _log.info("Probe found codec=%s, bitrate=%s", codec, bitrate) | ||
| return codec, bitrate |
There was a problem hiding this comment.
The else part should've been fine here.
| @@ -50,6 +50,22 @@ | |||
|
|
|||
| from .enums import Locale | |||
|
|
|||
| if sys.version_info >= (3, 11): | |||
| from inspect import iscoroutine as iscoroutine, iscoroutinefunction as iscoroutinefunction | |||
There was a problem hiding this comment.
iscoroutine isn't being used anywhere, as far as I can tell, and asyncio.iscoroutine isn't deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support python 3.14. All of our dependencies allow it at this point in time.
depends on #1328
Reviews/contributions are useful at any point in time.
Checklist
pdm lintpdm pyright